Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change libtiff dependency to pylibtiff #799

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Change libtiff dependency to pylibtiff #799

merged 2 commits into from
Mar 21, 2022

Conversation

mcovalt
Copy link
Contributor

@mcovalt mcovalt commented Mar 16, 2022

This PR updates the package name for pearu/pylibtiff.

It seems the official PyPI project name for pearu/pylibtiff changed from libtiff to pylibtiff as of October 21, 2021.

@mcovalt mcovalt marked this pull request as draft March 16, 2022 17:54
@mcovalt mcovalt changed the title Change to dependency to pylibtiff Change libtiff dependency to pylibtiff Mar 16, 2022
@manthey
Copy link
Member

manthey commented Mar 16, 2022

We'll need to update the large_image_wheels to emit libtiff as pylibtiff before we merge this.

@mcovalt mcovalt mentioned this pull request Mar 16, 2022
Closed
@mcovalt
Copy link
Contributor Author

mcovalt commented Mar 16, 2022

Tracked here: girder/large_image_wheels#29

@banesullivan
Copy link
Contributor

Drive-by comment that the conda-forge recipe should be good here (no changes needed): https://github.com/conda-forge/large-image-source-tiff-feedstock/blob/main/recipe/meta.yaml

@mcovalt mcovalt marked this pull request as ready for review March 17, 2022 13:53
@mcovalt
Copy link
Contributor Author

mcovalt commented Mar 17, 2022

Drive-by comment that the conda-forge recipe should be good here (no changes needed): https://github.com/conda-forge/large-image-source-tiff-feedstock/blob/main/recipe/meta.yaml

Awesome. I think after this PR you could drop the libtiff requirement there? Or is libtiff there referring to the actual libtiff library?

manthey
manthey reviewed Mar 17, 2022
View reviewed changes
sources/tiff/setup.py Outdated Show resolved Hide resolved
mcovalt added a commit that referenced this pull request Mar 17, 2022
@mcovalt
Remove the version limiter for pylibtiff
46327ad 
`pylibtiff` was only published as 0.4.4 (and our wheel which uses an artificially higher number to get priority).

@manthey
#799 (comment)
@mcovalt
Remove the version limiter for pylibtiff
42167f3 
`pylibtiff` was only published as 0.4.4 (and our wheel which uses an
artificially higher number to get priority).

@manthey
#799 (comment)
@banesullivan
Copy link
Contributor

Or is libtiff there referring to the actual libtiff library?

Yes, libtiff is referring to the libtiff library while pylibtiff are the Python wrappings. That is still necessary in the conda recipe

@banesullivan
Copy link
Contributor

Actually, libtiff isn't really needed as libtiff is pulled in bypylibtiff on conda

@mcovalt mcovalt merged commit d78dfb1 into master Mar 21, 2022
@mcovalt mcovalt deleted the libtiff-package branch March 21, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manthey manthey manthey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcovalt @manthey @banesullivan